Use an SVG sprite for the p5 logo. #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @toolness , I would like to know this details from p5.js-widget tool in this repo there is no discussions tab so i am asking in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses an SVG sprite for the p5 logo, which gives us a lot more control over how to style it via CSS. For example, it allows us to add the same hover effect that the toolbar buttons have, whereby the p5 logo can turn blue when the mouse is over it.
This works on the latest versions of Chrome and Firefox and Edge, but I'm not sure how good the browser support really is, especially since I'm not using any funky tools like SVGInjector to inject the SVG into the page DOM directly.